Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Update Cassandra chart version to latest" #765

Merged
merged 4 commits into from
Sep 12, 2020
Merged

Revert "Update Cassandra chart version to latest" #765

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1e719f
Revert "Update Cassandra chart version to latest (#755)"
Sep 12, 2020
bd2abe5
Merge branch 'master' into revert-755-app-cassandra-version-update
Sep 12, 2020
47afbe2
Update cassandra.go
Sep 12, 2020
b5b512e
Update cassandra.go
Sep 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/app/cassandra.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,17 @@ type CassandraInstance struct {
}

// NewCassandraInstance returns new cassandra application
// Last tested working version "0.13.3"
func NewCassandraInstance(name string) App {
return &CassandraInstance{
name: name,
chart: helm.ChartInfo{
Release: appendRandString(name),
RepoURL: helm.BitnamiRepoURL,
RepoName: helm.BitnamiRepoName,
RepoURL: helm.IncubatorRepoURL,
Chart: "cassandra",
RepoName: helm.IncubatorRepoName,
Version: "0.13.3",
Values: map[string]string{
"image.repository": "kanisterio/cassandra",
"image.repo": "kanisterio/cassandra",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be image.repository?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And further checking of #755 shows that image.repo is the correct revert. Removing hold-off label.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But... this file fail travis because it needs a gofmt.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will ask @arush-sal to take a look into this.

"image.tag": "0.34.0",
"config.cluster_size": "1",
},
Expand Down
4 changes: 0 additions & 4 deletions pkg/helm/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@ type HelmVersion string
const (
DefaultCommandTimeout = 5 * time.Minute

// Add Bitnami charts url
BitnamiRepoName = "bitnami"
BitnamiRepoURL = "https://charts.bitnami.com/bitnami"

// Add elastic charts url
ElasticRepoName = "elastic"
ElasticRepoURL = "https://helm.elastic.co"
Expand Down