Pass size of source while calling put for storage bucket from kando #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were passing the object size 0 when we called `.put` on the bucket of object storage and because of that `stow` was not able to figure out the source size and eventually multi part upload was not being triggered.
|
Please ignore the |
vkamra
reviewed
Nov 5, 2020
pkg/location/location.go
Outdated
| @@ -97,7 +98,12 @@ func writeData(ctx context.Context, pType objectstore.ProviderType, profile para | |||
| if err != nil { | |||
| return err | |||
| } | |||
| if err := bucket.Put(ctx, path, in, 0, nil); err != nil { | |||
| b, err := ioutil.ReadAll(in) | |||
There was a problem hiding this comment.
yeah, we discussed this in yesterday's call. We unknowingly introduced another issue here. After reading the in is going to be nil. I am working on this.
viveksinghggits
force-pushed
the
kando-source-size-fix
branch
from
570b7bb
to
58e4248
Compare
|
This requires the version of |
Signed-off-by: PrasadG193 <prasad.ghangal@gmail.com>
Signed-off-by: PrasadG193 <prasad.ghangal@gmail.com>
Signed-off-by: PrasadG193 <prasad.ghangal@gmail.com>
Signed-off-by: PrasadG193 <prasad.ghangal@gmail.com>
|
Unit tests run after updating |
|
tdmanv
approved these changes
Nov 11, 2020
pkg/location/location_test.go
Outdated
| // Create dump file | ||
| err := os.Truncate(s.testMultipartPath, fileSize) | ||
| c.Assert(err, IsNil) | ||
| testcontent, err := ioutil.ReadFile(s.testMultipartPath) |
There was a problem hiding this comment.
os.Open() will give you a reader - you don't need to get the content in-memory then create a bytes.Buffer.
There was a problem hiding this comment.
Now, we are re-using file pointer created at https://github.com/kanisterio/kanister/pull/809/files/147b928221ac56008f56f83ce76f2e525c764eee#diff-c1b47cb14ad134412666df8eff6311f52edc385a3e6ffa6a15564f24ec9b297bR150
Signed-off-by: PrasadG193 <prasad.ghangal@gmail.com>
Signed-off-by: PrasadG193 <prasad.ghangal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
We were passing the object size
0when we called.putonthe bucket of object storage and because of that whenever
stowtried to check if source size is more than the allowed size we didn't
get expected result.
This PR tries to fix that by passing the correct object size while calling
put.Depends on: #809
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
I tried to upload the file of size
1000M, if the size is greater that256Mmultipart upload for stow would be called.