-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/800/poetry-dependency-management: introduce poetry #929
feat/800/poetry-dependency-management: introduce poetry #929
Conversation
4555700
to
212e3eb
Compare
pyproject.toml
Outdated
"Programming Language :: Python :: 3.9", | ||
] | ||
license = "Apache-2.0" | ||
version = "0.31.0rc0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one fix: version should now be 0.31.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, fixed. I would also like to use something like https://github.com/tiangolo/poetry-version-plugin in next step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, didn't know about it! That's a great idea :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used similar solution in my personal projects, but there I've used https://flit.pypa.io/en/stable/
ce935d1
to
739a0d2
Compare
@jkrzemin this looks good thank you! Unfortunately we've done some requirements.txt updates along the way - I can submit those updates to your branch to fix the conflicts if you want 👍🏼 |
I'll update it by tomorrow |
Moves dependency and project management from setup.py to poetry.
739a0d2
to
b1556eb
Compare
@ramaro alright, I've updated the requirements in pyproject.toml - I've checked all packages added in requirements.txt within this year. |
Perfect, thank you @jkrzemin 👍🏼 |
Hi @jkrzemin, I noticed that your pull request was already merged, but unfortunately, it lacked documentation, and an outdated Dockerfile which has resulted in a failing build pipeline #942 . In the future, it would be helpful if you could prioritize documentation to ensure that our code is easily maintainable, and our build pipeline is successful. Moving forward, I would recommend that you update the code with the necessary documentation as soon as possible to ensure that our project code is up to our standards #941 . @ramaro It may also be worth considering adding another step to our review process to ensure that all changes include proper documentation before merging. Thank you for your contributions, and I appreciate your efforts and improvements. cc: @MatteoVoges |
Moves dependency and project management from setup.py to poetry.
Fixes issue #800
Proposed Changes