-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add dev, docs and test dependcies to Poetry #976
Conversation
Hey @gruzewski , Please make sure that the other workflows like building the docker image or building the documentation itself doesn't fail like with #929 . @ademariag @gburiola @ramaro @uberspot Is there a way we can test this beforehand? Can you unlock the tests withheld from the public? 😆 |
@MatteoVoges sure thing. I will build it (which I believe I have done it already). I will see if I can also test Github Actions with act but if there are a lot of secrets to provide, it might difficult to do. |
397c6c5
to
84ec7d3
Compare
I tested the building Docker image, and it looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@gruzewski can't we, using poetry, get rid of the venv documentation? |
@Moep90 we could, but I am pretty sure some people still prefer to use old |
@gruzewski If you rebase and solve the conflicts with running |
4ca2b9d
to
9b3e053
Compare
9b3e053
to
94687b6
Compare
f39c588
to
502e594
Compare
Update Poetry with new groups
Add Poetry group dependencies for development, documentation and testing. This change gathers dependencies declared in different files (
requirements.docs.txt
,README.md
,test.yml
), making creating a local development environment easier when contributing.This is a no-op as all groups are declared
optional
and existing installation methods are preserved.Testing:
I built and ran Kapitan's Docker container locally before removing the
compiled
directory.