splitted responsibilities #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mensfeld
added
the
enhancement
benissimo
reviewed
Jan 28, 2019
| @@ -82,16 +82,18 @@ class << self | |||
| # @param topic_name [Symbol, String] name of topic to which we want to respond | |||
| # @param options [Hash] hash with optional configuration details | |||
| def topic(topic_name, options = {}) | |||
| options[:serializer] ||= Karafka::App.config.serializer | |||
| options[:registered] = true | |||
There was a problem hiding this comment.
This makes the options.merge(registered: true) below redundant.
There was a problem hiding this comment.
@mensfeld ^ this is my only feedback.
benissimo
suggested changes
Jan 28, 2019
| @@ -82,16 +82,18 @@ class << self | |||
| # @param topic_name [Symbol, String] name of topic to which we want to respond | |||
| # @param options [Hash] hash with optional configuration details | |||
| def topic(topic_name, options = {}) | |||
| options[:serializer] ||= Karafka::App.config.serializer | |||
| options[:registered] = true | |||
There was a problem hiding this comment.
@mensfeld ^ this is my only feedback.
nijikon
reviewed
Jan 29, 2019
nijikon
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #463
cc: @benissimo
note: does not provide way to overwrite the default serializer in the responder as this will be provided in a different PR.