Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: move directories libusb and hidapi below internal/ #37

Closed
dolmen opened this issue Jan 13, 2022 · 1 comment
Closed

Proposal: move directories libusb and hidapi below internal/ #37

dolmen opened this issue Jan 13, 2022 · 1 comment

Comments

@dolmen
Copy link
Contributor

dolmen commented Jan 13, 2022

I propose to move directories libusb/ and hidapi/ below internal/.

This will allow to hide dummy Go packages that need to be introduced to allow vendoring (see #31).

I can do the work if this is accepted.

Note: this will impact #33, #34 (libusb, hidapi upgrade scripts).

@dolmen dolmen changed the title Move directories libusb and hidapi below internal/ Proposal: move directories libusb and hidapi below internal/ Jan 14, 2022
@dolmen
Copy link
Contributor Author

dolmen commented Feb 20, 2022

Dummy Go package are not the right solution because that would create Go packages with C files without cgo files, and go build doesn't like that.

#31 is not a solution to the vendoring problem.

The right solution is to have all files needed for the build in the package directory (no subdirectory), so this requires to flatten/inline libraries libusb and hidapi.

@dolmen dolmen closed this as completed Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant