Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement undo/redo in editor #58

Closed
andy840119 opened this issue Apr 10, 2020 · 6 comments
Closed

Implement undo/redo in editor #58

andy840119 opened this issue Apr 10, 2020 · 6 comments
Labels
editor Karaoke ruleset's editor area
Milestone
2022.0101

Comments

@andy840119
Copy link
Member

Wait until https://reurl.cc/E7RAKm merge.
@andy840119 andy840119 added the editor Karaoke ruleset's editor area label Apr 10, 2020
@andy840119
Copy link
Member Author

Only do LyricLine now because Note might be in the nasted object in LyricLine

@andy840119
Copy link
Member Author

andy840119 commented Apr 14, 2020 •
edited
Loading

Cannot implement now because EditorChangeHandler will call LegacyBeatmapEncoder.Encode at the start of the entry editor, which will cause crash.

@andy840119
Copy link
Member Author

Oops still cannot be used

@andy840119
Copy link
Member Author

Still need waiting.

@andy840119
Copy link
Member Author

Need to check is workable in customize ruleset.
Just need to add the code and doesn't need to make a check.

@andy840119
Copy link
Member Author

Guess already implemented in #957 and #964

@andy840119 andy840119 added this to the 2022.0101 milestone Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editor Karaoke ruleset's editor area
Projects
None yet
Milestone
2022.0101
Development

No branches or pull requests
1 participant
@andy840119