Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do some class/property renaming. #332

Open
andy840119 opened this issue Mar 25, 2023 · 0 comments
Open

Do some class/property renaming. #332

andy840119 opened this issue Mar 25, 2023 · 0 comments
Labels
code quality enhancement New feature or request

Comments

@andy840119
Copy link
Member

  • CustomizedShaderBufferedDrawNode -> CustomizedShaderDrawNode, not really sure still need Buffered or not 🤔
  • MultiShaderBufferedDrawNode and MultiShaderBufferedDrawNodeSharedData -> should remove the Buffered also.
  • StepShader.Draw -> Not really should change this name as Template because it's still render to the framebuffer, but not showing.
  • StepShader -> Guess should be better to rename as GroupShader because those shaders will render as a group.

Other:

  • Not really sure should have Draw property in every customized shader?
  • Not really sure should have something like NodeShader or TemplateShader for able make this shader as template or not.
@andy840119 andy840119 added enhancement New feature or request code quality labels Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant