Magento 2.2.8 All tracking links being dumped into shipping emails

[squeegy06]

Summary:

Shipping emails are outputting all tracking links from all orders instead of just showing the tracking links for the specific order after updating to Magento 2.2.8.

Preconditions:

1. Magento CE 2.2.8
2. Multiple orders with shipments that contain tracking links
3. The latest faonni/module-tracking-link installed.

Steps To Reproduce:

1. Create a new order.
2. Create a shipment for the new order, making sure to add a tracking link, and send an email confirmation to the customer.
3. Observe email.

Results

All tracking links from all orders are dumped to the email (limited only by Magento's default collection limit).

Expected Results

I expected only the tracking information for this order to be displayed.

I've already solved the issue and I'll be making a pull request shortly. It looks like in 2.2.8 and 2.3.x Magento changed the methods getting tracking information for a specific order, which is likely the cause of this issue. I've only tested this in 2.2.8 so I'm not 100% sure this behavior also exists in 2.3, but either way my change brings the template in line with how Magento outputs tracking information by default both in 2.2.8 and 2.3+.