Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip directory creation when reporting to console #86

Merged
merged 5 commits into from
Feb 3, 2015
Merged

fix: skip directory creation when reporting to console #86

merged 5 commits into from
Feb 3, 2015

Conversation

timothykang
Copy link
Contributor

Closes #24

@timothykang timothykang closed this Aug 1, 2014
@timothykang timothykang deleted the fix-skip-dir-creation branch August 1, 2014 01:06
@timothykang timothykang reopened this Aug 1, 2014
@timothykang timothykang closed this Aug 1, 2014
@timothykang timothykang reopened this Aug 1, 2014
@timothykang timothykang closed this Aug 1, 2014
@timothykang timothykang reopened this Aug 1, 2014
@aj-dev
Copy link

aj-dev commented Nov 17, 2014

Can someone merge this PR to master?

run()
expect(mockMkdir).not.to.have.been.called

rootConfig.coverageReporter.reporters = [{ type: 'text', file: 'file' }]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timothykang can you separate one test on three:

something like this:

it 'should not create directory if reporting to console', ->
it 'should create directory if reporting to file with type text`, ->
it 'should create directory if reporting to file with type text-summary`, ->

Thanks!

@timothykang
Copy link
Contributor Author

Test has been split up into two cases, with and without the file report parameter.

I believe the purpose of the try/catch is to prevent istanbul exceptions of one report/browser from interrupting others, which I believe is wise. It was already in the code prior to my changes (in onRunComplete), and I moved it to preserve the existing code as much as possible and to keep things DRY.

@maksimr
Copy link
Contributor

maksimr commented Nov 18, 2014

@timothykang Thanks!

LGTM

/cc @aymericbeaumet

@hiebj
Copy link

hiebj commented Feb 3, 2015

when can we expect this to be merged?

@aymericbeaumet
Copy link
Member

My bad, forgot to answer after looking the PR when @maksimr's pinged me. LGTM.

aymericbeaumet added a commit that referenced this pull request Feb 3, 2015
fix: skip directory creation when reporting to console
@aymericbeaumet aymericbeaumet merged commit 4a1d186 into karma-runner:master Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console only output still makes files.
5 participants