-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip directory creation when reporting to console #86
fix: skip directory creation when reporting to console #86
Conversation
Can someone merge this PR to master? |
run() | ||
expect(mockMkdir).not.to.have.been.called | ||
|
||
rootConfig.coverageReporter.reporters = [{ type: 'text', file: 'file' }] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timothykang can you separate one test on three:
something like this:
it 'should not create directory if reporting to console', ->
it 'should create directory if reporting to file with type text`, ->
it 'should create directory if reporting to file with type text-summary`, ->
Thanks!
Test has been split up into two cases, with and without the I believe the purpose of the |
@timothykang Thanks! LGTM /cc @aymericbeaumet |
Conflicts: lib/reporter.js
when can we expect this to be merged? |
My bad, forgot to answer after looking the PR when @maksimr's pinged me. LGTM. |
fix: skip directory creation when reporting to console
Closes #24