fix(common): Proxy function toString does not contain Proxy. #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent change (https://www.chromestatus.com/feature/5666372071718912) means Proxied functions no longer throw TypeError. Change the test to conform to the new reality.
|
What about all the old browsers that don't implement this change? |
|
Older browsers should work fine, they just won't have fix-up serialization of proxy functions. I think that is a good trade off: rather than complex code for every browser we lose rare corner case support for old browsers. (This issue now breaks the build since travis is runner chrome 66) |
This was referenced Apr 30, 2018
zzo
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent change (https://www.chromestatus.com/feature/5666372071718912) means Proxied functions
no longer throw TypeError. Change the test to conform to the new reality.
Fixes #2942