refactor(watcher): refactor watcher.js #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
requested changes
Apr 22, 2018
lib/watcher.js
Outdated
| return p !== path && path.substr(0, p.length + 1) === p + DIR_SEP | ||
| })) { | ||
| pathsToWatch.forEach(path => { | ||
| if (![...pathsToWatch].some(p => p !== path && path.substr(0, p.length + 1) === p + DIR_SEP)) { |
There was a problem hiding this comment.
this is very inefficient doing the conversion to an array inside the loop
lib/watcher.js
Outdated
| function getWatchedPatterns (patterns) { | ||
| return patterns | ||
| .filter(pattern => pattern.watched) | ||
| .map(pattern => pattern.pattern) |
There was a problem hiding this comment.
while we are changing this code, lets use use either reduce, a for loop or underscore to avoid doing two iterations
lib/watcher.js
Outdated
| .on('add', path => fileList.addFile(helper.normalizeWinPath(path))) | ||
| .on('change', path => fileList.changeFile(helper.normalizeWinPath(path))) | ||
| .on('unlink', path => fileList.removeFile(helper.normalizeWinPath(path))) | ||
| .on('error', log.debug) |
There was a problem hiding this comment.
better to do log.debug.bind(log) to be on the safe side here
|
@dignifiedquire |
|
AppVeyor (only Node v4) fails with error, that seems to not be related with this PR. Any idea how to fix ? |
|
Actually node 4 fails then appveyor bails and no tests run on other versions. I think this is related to #2951 |
dignifiedquire
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplify a bit logic in
watcher.jsmethod.