refactor: migrate lib/events.js into ES6 #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lusarz
commented
May 22, 2018
| @@ -24,7 +24,9 @@ var BaseLauncher = function (id, emitter) { | |||
| Object.keys(EventEmitter.prototype).forEach(function (method) { | |||
| this[method] = EventEmitter.prototype[method] | |||
| }, this) | |||
| KarmaEventEmitter.call(this) | |||
|
|
|||
| this.bind = KarmaEventEmitter.prototype.bind.bind(this) | |||
There was a problem hiding this comment.
This trick was needed because of cannot calls KarmaEventEmitter without new operator like error. I have plan to do further refactoring, and transform BaseLauncher into regular ES6 class.
johnjbarton
suggested changes
May 23, 2018
lib/events.js
Outdated
|
|
||
| eventsToBuffer.forEach(function (eventName) { | ||
| var listener = genericListener.bind(null, eventName) | ||
| eventsToBuffer.forEach(eventName => { |
There was a problem hiding this comment.
We seem to have -- mostly -- been using parens even for the one-argument case:
eventsToBuffer.forEach((eventName) => {
This form is more instantly readable as a function and makes adding/removing args easy.
(A couple of places)
There was a problem hiding this comment.
Ok, I understand and will improve it.
What do you think about update eslint configuration with arrow-parens rule to catch such cases? I can do pr for that.
johnjbarton
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within this pull request I moved lib/events into ES6 class. In next iteration I'm planning to migrate pseudo-classes that extends
KarmaEventEmitterinto classes.