Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 2.0.3: Use for...in to bind EventEmitter functions #3057

Closed
johnjbarton opened this issue Jun 20, 2018 · 1 comment · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132
Closed

Regression in 2.0.3: Use for...in to bind EventEmitter functions #3057

johnjbarton opened this issue Jun 20, 2018 · 1 comment · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122 or Omrisnyk/npm-lockfiles#132

Comments

@johnjbarton
Copy link
Contributor

The PR

refactor(events): refactor karma EventEmitter (#3012)

8197408

misfired: we need to iterate the objects prototype, not just the own enumerable functions.
johnjbarton added a commit to johnjbarton/karma that referenced this issue Jun 20, 2018
@johnjbarton
fix(events): bind emitters with for..in.
f7852f6 
Fixes karma-runner#3057
@johnjbarton johnjbarton mentioned this issue Jun 20, 2018
Merged
johnjbarton added a commit that referenced this issue Jun 20, 2018
@johnjbarton
fix(events): bind emitters with for..in. (#3059)
b99f03f 
Fixes #3057
@nicojs
Copy link
Contributor

nicojs commented Jun 30, 2018

Wow! Took me a few hours to find this one. I had 2 sets of integration tests, one using 2.0.2 , one using 2.0.3. Big head scratcher. Thanks for fixing! 🤝

@karronoli karronoli mentioned this issue Aug 16, 2022
Merged
@Omrisnyk Omrisnyk mentioned this issue Oct 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this issue Dec 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@johnjbarton @nicojs