Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): move puppeteer from dependency to dev-dependency #3193

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

johnjbarton
Copy link
Contributor

Fixes #3191
Thanks to @davidshepherd7 for suggesting this.

@johnjbarton
Copy link
Contributor Author

@lusarz
This PR looks like it may cause
" Starting browser chrome (linux) on SauceLabs"
to fail. Could puppeteer cause this?

@lusarz
Copy link
Contributor

lusarz commented Oct 23, 2018

@johnjbarton Do you have link to CI build where it fails ?

@johnjbarton
Copy link
Contributor Author

I'm unsure what is going on
Here the pull request #3193 passes
https://travis-ci.org/karma-runner/karma/builds/444825046

Here the release fails
https://travis-ci.org/karma-runner/karma/builds/445228793

The full build history
https://travis-ci.org/karma-runner/karma/builds

@lusarz
Copy link
Contributor

lusarz commented Oct 30, 2018

@johnjbarton Do you think it may be related with this part of code:

if (TRAVIS_WITHOUT_BS) {
browsers.push('Firefox')
} else {
browsers = Object.keys(launchers)
}

and different env variables values for pr vs release build ?

@johnjbarton
Copy link
Contributor Author

If we changed that conf.js to log the process env values we might get more info and anyway this kind of travis-only config should be logged since it can be so surprising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants