-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make verify-codegen.sh script works properly on GitHub Action #1221
Conversation
3aed5c4
to
6a30371
Compare
@iawia002 Excellent. Can you explain a little bit? |
Hi @XiShanYongYe-Chang I have updated the description of PR, see #1220 for background and more info. |
Thanks, I see it. |
Hi, @iawia002 , my own CI can still pass, is there any problem that still existing? https://github.com/XiShanYongYe-Chang/karmada/runs/4735815303?check_suite_focus=true |
Cause your repo name is |
Ok, I got it. In this case, for the individual branch, it is impossible to detect that the CI fails in time. |
I will update the path config to support this case. |
Signed-off-by: Xinzhao Xu <z2d@jifangcheng.com>
Signed-off-by: Xinzhao Xu <z2d@jifangcheng.com>
8347cbe
to
fc20a6c
Compare
@XiShanYongYe-Chang Can you test 336b979 commit again? |
Yes, let me test it. |
@iawia002 nice 👍 , it works as expected: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Excellent!!!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Xinzhao Xu z2d@jifangcheng.com
What type of PR is this?
/kind flake
What this PR does / why we need it:
See our discussion in #1220
The cause of the problem is: in the GitHub Action environment, our code is not in the
GOPATH/src/github.com
directory, but thedeepcopy-gen
generates the code into the GOPATH directory, so the deep copy files in the current directory don't actually been updated, this makes our diff tests to always pass.So I have updated the work directory config in CI to fix this issue.
Which issue(s) this PR fixes:
Fixes #1220
Special notes for your reviewer:
Does this PR introduce a user-facing change?: