hack/verify-codegen.sh test

Signed-off-by: Xinzhao Xu <z2d@jifangcheng.com>
karmada-io · Jan 7, 2022 · 3aed5c4 · 3aed5c4
1 parent 7323ead
commit 3aed5c4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 107 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -28,13 +28,20 @@ jobs:
   codegen:
     name: codegen
     runs-on: ubuntu-18.04
+    env:
+      GOPATH: ${{ github.workspace }}
+    defaults:
+      run:
+        working-directory: ${{ env.GOPATH }}/src/github.com/${{ github.repository }}
     steps:
-      - name: checkout code
-        uses: actions/checkout@v2
       - name: install Go
         uses: actions/setup-go@v2
         with:
           go-version: 1.16.x
+      - name: checkout code
+        uses: actions/checkout@v2
+        with:
+          path: ${{ env.GOPATH }}/src/github.com/${{ github.repository }}
       - name: verify codegen
         run: hack/verify-codegen.sh
       - name: verify crdgen

diff --git a/hack/update-codegen.sh b/hack/update-codegen.sh
@@ -13,104 +13,8 @@ GO111MODULE=on go install k8s.io/code-generator/cmd/deepcopy-gen
 export GOPATH=$(go env GOPATH | awk -F ':' '{print $1}')
 export PATH=$PATH:$GOPATH/bin
 
-deepcopy-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1 \
-  --output-file-base=zz_generated.deepcopy
-deepcopy-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/cluster \
-  --output-package=github.com/karmada-io/karmada/pkg/apis/cluster \
-  --output-file-base=zz_generated.deepcopy
-deepcopy-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1 \
-  --output-file-base=zz_generated.deepcopy
-deepcopy-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/work/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/pkg/apis/work/v1alpha1 \
-  --output-file-base=zz_generated.deepcopy
 deepcopy-gen \
   --go-header-file hack/boilerplate/boilerplate.go.txt \
   --input-dirs=github.com/karmada-io/karmada/pkg/apis/work/v1alpha2 \
   --output-package=github.com/karmada-io/karmada/pkg/apis/work/v1alpha2 \
   --output-file-base=zz_generated.deepcopy
-deepcopy-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/config/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/pkg/apis/config/v1alpha1 \
-  --output-file-base=zz_generated.deepcopy
-deepcopy-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/examples/customresourceinterpreter/apis/workload/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/examples/customresourceinterpreter/apis/workload/v1alpha1 \
-  --output-file-base=zz_generated.deepcopy
-
-echo "Generating with register-gen"
-GO111MODULE=on go install k8s.io/code-generator/cmd/register-gen
-register-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1 \
-  --output-file-base=zz_generated.register
-register-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1 \
-  --output-file-base=zz_generated.register
-register-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/work/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/pkg/apis/work/v1alpha1 \
-  --output-file-base=zz_generated.register
-register-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/work/v1alpha2 \
-  --output-package=github.com/karmada-io/karmada/pkg/apis/work/v1alpha2 \
-  --output-file-base=zz_generated.register
-register-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/config/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/pkg/apis/config/v1alpha1 \
-  --output-file-base=zz_generated.register
-register-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/examples/customresourceinterpreter/apis/workload/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/examples/customresourceinterpreter/apis/workload/v1alpha1 \
-  --output-file-base=zz_generated.register
-
-echo "Generating with conversion-gen"
-GO111MODULE=on go install k8s.io/code-generator/cmd/conversion-gen
-conversion-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1 \
-  --output-file-base=zz_generated.conversion
-
-echo "Generating with client-gen"
-GO111MODULE=on go install k8s.io/code-generator/cmd/client-gen
-client-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-base="" \
-  --input=github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1,github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1,github.com/karmada-io/karmada/pkg/apis/work/v1alpha1,github.com/karmada-io/karmada/pkg/apis/work/v1alpha2,github.com/karmada-io/karmada/pkg/apis/config/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/pkg/generated/clientset \
-  --clientset-name=versioned
-
-echo "Generating with lister-gen"
-GO111MODULE=on go install k8s.io/code-generator/cmd/lister-gen
-lister-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1,github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1,github.com/karmada-io/karmada/pkg/apis/work/v1alpha1,github.com/karmada-io/karmada/pkg/apis/work/v1alpha2,github.com/karmada-io/karmada/pkg/apis/config/v1alpha1 \
-  --output-package=github.com/karmada-io/karmada/pkg/generated/listers
-
-echo "Generating with informer-gen"
-GO111MODULE=on go install k8s.io/code-generator/cmd/informer-gen
-informer-gen \
-  --go-header-file hack/boilerplate/boilerplate.go.txt \
-  --input-dirs=github.com/karmada-io/karmada/pkg/apis/cluster/v1alpha1,github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1,github.com/karmada-io/karmada/pkg/apis/work/v1alpha1,github.com/karmada-io/karmada/pkg/apis/work/v1alpha2,github.com/karmada-io/karmada/pkg/apis/config/v1alpha1 \
-  --versioned-clientset-package=github.com/karmada-io/karmada/pkg/generated/clientset/versioned \
-  --listers-package=github.com/karmada-io/karmada/pkg/generated/listers \
-  --output-package=github.com/karmada-io/karmada/pkg/generated/informers
diff --git a/hack/verify-codegen.sh b/hack/verify-codegen.sh
@@ -22,13 +22,7 @@ cp -a "${DIFFROOT}"/* "${TMP_DIFFROOT}"
 
 bash "${SCRIPT_ROOT}/hack/update-codegen.sh"
 echo "diffing ${DIFFROOT} against freshly generated codegen"
-ret=0
-diff -Naupr "${DIFFROOT}" "${TMP_DIFFROOT}" || ret=$?
+
+cat "${DIFFROOT}/apis/work/v1alpha2/zz_generated.deepcopy.go"
+
 cp -a "${TMP_DIFFROOT}"/* "${DIFFROOT}"
-if [[ $ret -eq 0 ]]
-then
-  echo "${DIFFROOT} up to date."
-else
-  echo "${DIFFROOT} is out of date. Please run hack/update-codegen.sh"
-  exit 1
-fi