Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] schedule workflow support workflow dispatch #4115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Oct 10, 2023

What type of PR is this?

/kind cleanup
/kind failing-test

What this PR does / why we need it:

Let schedule workflow support call normal and we should need the all of job result, so do not fail-fast for APIServer compatibility, Run all of workflow job for all of version.

It's all failed in my fork repo of karmada.

image

Which issue(s) this PR fixes:
Releated: #4111

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Lan Liang <gcslyp@gmail.com>
@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Oct 10, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rainbowmango after the PR has been reviewed.
You can assign the PR to them by writing /assign @rainbowmango in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2023
@liangyuanpeng
Copy link
Contributor Author

/assign @RainbowMango

@liangyuanpeng
Copy link
Contributor Author

Run workflow once immediately would be great after this PR is merged.

lan@lan:~/repo/git$ export GITHUB_TOKEN=123
lan@lan:~/repo/git$ cd karmada
lan@lan:~/repo/git/karmada$ gh workflow run -R karmada-io/karmada
? Select a workflow  [Use arrows to move, type to filter]
> APIServer compatibility (ci-schedule-compatibility.yaml)

Choose the APIServer compatibility and run it.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ff433ce) 53.50% compared to head (a3c9d4a) 53.49%.
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4115      +/-   ##
==========================================
- Coverage   53.50%   53.49%   -0.01%     
==========================================
  Files         234      234              
  Lines       23281    23281              
==========================================
- Hits        12457    12455       -2     
- Misses      10143    10145       +2     
  Partials      681      681              
Flag Coverage Δ
unittests 53.49% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangyuanpeng
Copy link
Contributor Author

@RainbowMango

Do you have any concerns about this PR? If you don't want to be able to manually call these two workflows currently, then I think at least APIServer compatibility should not fail quickly, and we need to know all the results, Remind me if i missed something,Thanks,

@jwcesign
Copy link
Member

jwcesign commented Nov 8, 2023

at least APIServer compatibility should not fail quickly

+1

@@ -11,6 +12,7 @@ jobs:
if: ${{ github.repository == 'karmada-io/karmada' }}
runs-on: ubuntu-22.04
strategy:
fail-fast: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,5 +1,6 @@
name: APIServer compatibility
on:
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow_dispatch can trigger the workflow manually. Does that mean all developers can trigger the workflow at anytime?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any concerns about this PR? If you don't want to be able to manually call these two workflows currently, then I think at least APIServer compatibility should not fail quickly,

Yes, it makes sense to me that let the scheduled workflow continue to run and avoid canceling due to other job failures.
But manually triggering the workflow is concerning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly ping @liangyuanpeng

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RainbowMango I have move the change of fail-fast: false to #4238 and there are fix a problem of timeout.

I want to keep this PR is open and i think let the workflow support workflow dispatch still relevant. Because I have done some exploration on combining this scheduled task with prow, I hope I will have an update on this aspect soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants