Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test env timeout of APIServer compatibility #4238

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Nov 14, 2023

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of #4111

Special notes for your reviewer:

this PR have two change:

  • let workflow of APIServer compatibility do not fail-fast
  • split the step of setup e2e test environment to fix timeout

Since the workflow is scheduled to trigger, I will trigger it immediately in my repo.

https://github.com/liangyuanpeng/karmada/actions/runs/6864906349
This workflow is working for reproduce to problem of setup e2e test env timeout.
The error log say:

...
Waiting for running............................................................................................................................................................................................................................................................................................................
Error:  Timeout waiting for condition running
Error: Process completed with exit code 1.

And this workflow is working for fix poblem of timeout. https://github.com/liangyuanpeng/karmada/actions/runs/6865184671

There are some job is failed due to the propagation Job failed when the karmada-apiserver version great then v1.27
PR #4160 will be fix it.

...
[FAILED] in [It] - /home/runner/work/karmada/karmada/test/e2e/resource_test.go:380 @ 11/15/23 02:07:12.449
  STEP: Removing PropagationPolicy(karmadatest-9fblz/job-t2h9r) @ 11/15/23 02:07:12.449
  STEP: Removing Job(karmadatest-9fblz/job-t2h9r) @ 11/15/23 02:07:12.453
  << Timeline

  [FAILED] Timed out after 300.000s.
  Expected
      <bool>: false
  to equal
      <bool>: true
  In [It] at: /home/runner/work/karmada/karmada/test/e2e/resource_test.go:380 @ 11/15/23 02:07:12.449

  Full Stack Trace
    github.com/karmada-io/karmada/test/e2e.glob..func30.6.3.1()
    	/home/runner/work/karmada/karmada/test/e2e/resource_test.go:380 +0x450
    github.com/karmada-io/karmada/test/e2e.glob..func30.6.3()
    	/home/runner/work/karmada/karmada/test/e2e/resource_test.go:366 +0x94
------------------------------
[SynchronizedAfterSuite] PASSED [0.009 seconds]
[SynchronizedAfterSuite] 
/home/runner/work/karmada/karmada/test/e2e/suite_test.go:137
------------------------------
• [INTERRUPTED] [15.937 seconds]
propagation with label and group constraints testing Job propagation testing [It] Job propagation with label and group constraints testing
/home/runner/work/karmada/karmada/test/e2e/scheduling_test.go:285

  Captured StdOut/StdErr Output >>
  MaxGroups= 1, MinGroups= 1
  target clusters in cluster resource binding are [member1]
  I1115 02:07:01.831005   50198 job.go:47] Waiting for job(karmadatest-nd4cz/job-wsc2q) synced on cluster(member1)
  << Captured StdOut/StdErr Output

  Timeline >>
  STEP: Creating PropagationPolicy(karmadatest-nd4cz/job-wsc2q) @ 11/15/23 02:06:56.786
  STEP: Creating Job(karmadatest-nd4cz/job-wsc2q) @ 11/15/23 02:06:56.806
  STEP: Get job(job-wsc2q) @ 11/15/23 02:06:56.812
  STEP: collect the target clusters in resource binding @ 11/15/23 02:06:56.817
  STEP: check if the scheduled condition is true @ 11/15/23 02:07:01.825
  STEP: check if job present on right clusters @ 11/15/23 02:07:01.83
  [INTERRUPTED] in [It] - /home/runner/work/karmada/karmada/test/e2e/scheduling_test.go:285 @ 11/15/23 02:07:12.698
  STEP: Removing Job(karmadatest-nd4cz/job-wsc2q) @ 11/15/23 02:07:12.7
  STEP: Removing PropagationPolicy(karmadatest-nd4cz/job-wsc2q) @ 11/15/23 02:07:12.71
  << Timeline

  [INTERRUPTED] Interrupted by Other Ginkgo Process
  In [It] at: /home/runner/work/karmada/karmada/test/e2e/scheduling_test.go:285 @ 11/15/23 02:07:12.698

  Full Stack Trace
------------------------------
• [INTERRUPTED] [297.406 seconds]
[JobReplicaScheduling] JobReplicaSchedulingStrategy testing ReplicaSchedulingType is Divided, ReplicaDivisionPreference is Weighted, WeightPreference isn't nil, spec.completions isn`t nil. [It] job replicas divided and weighted testing
...

image

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Nov 14, 2023
@liangyuanpeng liangyuanpeng marked this pull request as draft November 14, 2023 14:16
@karmada-bot karmada-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@bb1d2e8). Click here to learn what that means.
Report is 6 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4238   +/-   ##
=========================================
  Coverage          ?   52.81%           
=========================================
  Files             ?      240           
  Lines             ?    23595           
  Branches          ?        0           
=========================================
  Hits              ?    12462           
  Misses            ?    10456           
  Partials          ?      677           
Flag Coverage Δ
unittests 52.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangyuanpeng liangyuanpeng marked this pull request as ready for review November 15, 2023 07:31
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2023
@liangyuanpeng
Copy link
Contributor Author

Actually, this pr have not find the root cause, it just split the step of setup e2e test environment, But it does work.

@liangyuanpeng
Copy link
Contributor Author

/cc @RainbowMango @jwcesign

Signed-off-by: Lan Liang <gcslyp@gmail.com>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Leave LGTM to @jwcesign

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@jwcesign
Copy link
Member

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwcesign, RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit d2c0746 into karmada-io:master Nov 15, 2023
12 checks passed
@pulsarsigs-bot pulsarsigs-bot deleted the fix_test_timeout branch November 15, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants