-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix test env timeout of APIServer compatibility #4238
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4238 +/- ##
=========================================
Coverage ? 52.81%
=========================================
Files ? 240
Lines ? 23595
Branches ? 0
=========================================
Hits ? 12462
Misses ? 10456
Partials ? 677
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6bf530b
to
1413622
Compare
Actually, this pr have not find the root cause, it just split the step of |
Signed-off-by: Lan Liang <gcslyp@gmail.com>
1413622
to
3bdd7d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Leave LGTM to @jwcesign
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwcesign, RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #4111
Special notes for your reviewer:
this PR have two change:
APIServer compatibility
do not fail-faste2e test environment
to fix timeoutSince the workflow is scheduled to trigger, I will trigger it immediately in my repo.
https://github.com/liangyuanpeng/karmada/actions/runs/6864906349
This workflow is working for reproduce to problem of setup e2e test env timeout.
The error log say:
And this workflow is working for fix poblem of timeout. https://github.com/liangyuanpeng/karmada/actions/runs/6865184671
There are some job is failed due to the propagation
Job
failed when thekarmada-apiserver
version great then v1.27PR #4160 will be fix it.
Does this PR introduce a user-facing change?: