Skip to content
This repository has been archived by the owner on Jun 30, 2018. It is now read-only.

Index should bulk store to its own URL endpoint (fixes #327) #328

Closed
wants to merge 2 commits into from
Closed

Index should bulk store to its own URL endpoint (fixes #327) #328

wants to merge 2 commits into from

Conversation

nz
Copy link
Contributor

@nz nz commented Apr 30, 2012

The Index#bulk_import method (index.rb:123), and other index methods, interact with the Cluster URL rather than their own Index URL endpoint.

This pull request refactors the index URL endpoint into the Index#url getter method, refactors a number of methods to use this new getter for clarity, and changes the bulk_import method to use this index-level endpoint rather than the cluster-level URL endpoint.

Also updated/refactored test expectations accordingly.

This fixes issues (e.g., #327) for users trying to configure Tire to use a single application index and who do not have access to cluster-level methods like /_bulk in production.


If anyone following along wants to test, try this in your Gemfile:

gem 'tire', git: 'git@github.com:nz/tire', branch: 'index-bulk-import-to-index-endpoint'

@karmi karmi closed this in e3fbd2c May 3, 2012
@nz
Copy link
Contributor Author

nz commented May 3, 2012

thanks! ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants