Skip to content
This repository has been archived by the owner on Jun 30, 2018. It is now read-only.

Add --data-binary as curl switch for logs when bulk loading (as per docs) #452

Closed

Conversation

canadaduane
Copy link
Contributor

The curl output should use --data-binary instead of -d when describing the action in the Tire log output. See http://www.elasticsearch.org/guide/reference/api/bulk.html.

Also adds count of omitted documents in log output.

…lasticSearch.org docs). Count number of documents in log output.
@karmi
Copy link
Owner

karmi commented Oct 23, 2012

Well, I think the docs say that you should use the option when you're providing the payload as @file. Nevertheless, the curl log is just informational as it is -- otherwise it would dump loads of payload data into your log... Leaning towards closing this?

@canadaduane
Copy link
Contributor Author

Well, it just tripped me up when trying to debug. It would be a time saver
in rare cases, if it didn't slightly mislead.
On Oct 23, 2012 10:38 AM, "Karel Minarik" notifications@github.com wrote:

Well, I think the docs say that you should use the option when you're
providing the payload as @file. Nevertheless, the curl log is just
informational as it is -- otherwise it would dump loads of payload data
into your log... Leaning towards closing this?


Reply to this email directly or view it on GitHubhttps://github.com//pull/452#issuecomment-9708846.

@karmi karmi closed this in 18284e7 Oct 26, 2012
@karmi
Copy link
Owner

karmi commented Oct 26, 2012

OK, thanks, merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants