Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim Mailadress or URL when it contains spacing #393

Open
navid-kalaei opened this issue Feb 7, 2022 · 4 comments
Open

trim Mailadress or URL when it contains spacing #393

navid-kalaei opened this issue Feb 7, 2022 · 4 comments
Assignees

Comments

@navid-kalaei
Copy link

(So far error an unnessesary spacing is only warned, when before and afterwards a letter is following)

Alternatively: Automatically delte all spacings in the field of URL and Mail

#134

@navid-kalaei
Copy link
Author

@wellemut even though I trim the emails and urls on the front end still backend needs to verify and trim the payload itself, otherwise third parties will be able to send incorrect data to ofdb. what do you think? should I do that to save time or wait for the right solution on the backend?

@wellemut
Copy link
Member

wellemut commented Feb 8, 2022

@uklotzde what do you think is better?
A. Shall the Frontend trim spacings before and after the mail and web address
B. Or do you want to solve this directly in the backend?

@uklotzde
Copy link
Member

uklotzde commented Feb 8, 2022

The backend should be responsible for normalizing data and for any mandatory data validation before storing data persistently. Only valid and normalized data should get into the database.

@wellemut
Copy link
Member

wellemut commented Feb 8, 2022

Ok, great,
So I move this issue to the ofDB.
That means, Navids frontend can send additional spacings and the backend cleans it.

@wellemut wellemut transferred this issue from kartevonmorgen/kartevonmorgen.ts Feb 8, 2022
@wellemut wellemut changed the title Show error message when Mailadress or URL contains spacing trim Mailadress or URL when it contains spacing Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants