Update star-rating.js #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a new Parameter addCaptionAsTitle was added, which is set in displayOnly Mode to true but only when it isn't manually set. So it is still possible to disable it. When addCaptionAsTitle = true the caption "content" is set as the title html attribute to the stars containing div. So you would get the correct value on hover. The parameter showCaption isn't disabled in displayOnly = true automatically any more. So the caption could be rendered in displayOnly mode. If the caption shouldn't be shown it has to be disabled manually. I just get the caption content by using the text() function. But of course an additional function which only returns the caption text like fetchCaptionValue would also be possible and maybe even better.
kartik-v
added a commit
that referenced
this pull request
Sep 15, 2018
kartik-v
added a commit
that referenced
this pull request
Sep 15, 2018
kartik-v
added a commit
that referenced
this pull request
Sep 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This pull request includes a
Changes
The following changes were made
Which is set to true in displayOnly Mode but only when it isn't manually set.
So it is still possible to disable it.
When addCaptionAsTitle = true the caption "content" is set as the title html attribute to the stars containing div.
So you would get the correct value on hover
I just get the caption content by using the text() function.
But of course an additional function which only returns the caption text like fetchCaptionValue would also be possible and maybe even better.
So the caption could be rendered in displayOnly mode.
If the caption shouldn't be shown it has to be disabled manually.
Related Issues
#177