This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
Updating to v1.0.0 with node mapnik v3.7.2 #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdholloway this PR is blocked until all the libraries are published, but if you are going to test you should use this code. |
Also, updating kartotherian version once it is stable enough to have a major version
|
Please disregard the last comment, I don't seem to have been looking at the most recent version of this PR. ;) |
mdholloway
suggested changes
Aug 5, 2018
Dockerfile
Outdated
| @@ -1,5 +1,8 @@ | |||
| FROM debian:stretch | |||
| RUN apt-get update && apt-get install -y nodejs nodejs-legacy git wget python libcairo2-dev libjpeg62-turbo-dev libpango1.0-dev libgif-dev build-essential g++ libmapnik-dev && rm -rf /var/lib/apt/lists/* | |||
| RUN apt-get update && apt-get install -y nodejs nodejs-legacy git wget python apt-transport-https libboost-filesystem-dev libboost-program-options-dev libboost-regex-dev libboost-system-dev libboost-thread-dev libxml2 libxml2-dev libfreetype6 libfreetype6-dev libjpeg-dev libpng-dev libtiff5-dev libcairo2 libcairo2-dev ttf-unifont ttf-dejavu ttf-dejavu-core ttf-dejavu-extra build-essential libgdal-dev libharfbuzz-bin libharfbuzz-dev libmapnik-dev && rm -rf /var/lib/apt/lists/* | |||
There was a problem hiding this comment.
It is not necessary to explicitly install most of these; they'll be pulled in as needed by libmapnik3.0.
mdholloway
suggested changes
Aug 5, 2018
package.json
Outdated
| "bluebird": "^3.5.0", | ||
| "body-parser": "^1.17.1", | ||
| "bunyan": "^1.8.9", | ||
| "cassandra-uuid": "^0.0.2", | ||
| "colors": "^1.3.1", |
There was a problem hiding this comment.
This looks like a new dependency. Where is it used?
Removing package installed by mistake. Reducing Dockerfile debian packages.
mdholloway
approved these changes
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating libraries to match node mapnik v3.72 on kartotherian and its dependencies