Review Repository/PaginatedRepository use.

[pedrovgs]

To use a PaginatedRepository implementation we have to extend from PaginatedRepository and write code like this:

  @Inject public CharactersRepository(CharacterDataSourceFactory characterDataSourceFactory,
      @Named(ApplicationModule.CHARACTERS_PAGE_IN_MEMORY_CACHE)
      PaginatedCacheDataSource<String, Character> inMemoryPaginatedCache,
      @Named(ApplicationModule.CHARACTERS_IN_MEMORY_CACHE)
      CacheDataSource<String, Character> inMemoryCache) {
    addCacheDataSources(inMemoryCache);
    addPaginatedCacheDataSources(inMemoryPaginatedCache);

    CharacterDataSource characterDataSource = characterDataSourceFactory.createDataSource();
    addReadableDataSources(characterDataSource);
    addPaginatedReadableDataSources(characterDataSource);
  }

We should review this implementation to do not need to add the data source to the cache data sources list and the paginated list. We should just configure the same data source once because a paginated data source should be used as a normal data source.

The usage of the repository should be something like:

  @Inject public CharactersRepository(CharacterDataSourceFactory characterDataSourceFactory,
      @Named(ApplicationModule.CHARACTERS_PAGE_IN_MEMORY_CACHE)
      PaginatedCacheDataSource<String, Character> inMemoryPaginatedCache) {
    addPaginatedCacheDataSources(inMemoryPaginatedCache);

    CharacterDataSource characterDataSource = characterDataSourceFactory.createDataSource();
    addPaginatedReadableDataSources(characterDataSource);
  }