Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

AppCompatActivity #46

Closed
sargunv opened this issue Mar 3, 2016 · 2 comments
Closed

AppCompatActivity #46

sargunv opened this issue Mar 3, 2016 · 2 comments
Assignees
@flipper83
Labels
enhancement

Comments

@sargunv
Copy link
Contributor

sargunv commented Mar 3, 2016

RosieActivity should extend from AppCompatActivity (or make a new RosieAppCompatActivity) to allow using things like setSupportActionBar()

I think there is no downside to changing RosieActivity to extend AppCompatActivity since both extend FragmentActivity and Rosie already depends on the support library.
@flipper83 flipper83 self-assigned this Mar 3, 2016
@flipper83
Copy link
Member

Hi @sargunster ,

Makes sense a RosieAppCompactActivity that it is equals to RosieActivity extending from AppCompactActivity.

Feel free to send a PullRequest with the new activity.

Thank you.

@sargunv
Copy link
Contributor Author

sargunv commented Mar 3, 2016

Will send a PR soon.

sargunv added a commit to sargunv/Rosie that referenced this issue Mar 3, 2016
@sargunv
RosieAppCompatActivity to fix Karumi#46
c2b04fd
@sargunv sargunv mentioned this issue Mar 3, 2016
Merged
@sargunv sargunv mentioned this issue Apr 3, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flipper83 flipper83

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sargunv @flipper83