Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go vendoring? #28

Closed
ilovezfs opened this issue Jun 9, 2017 · 5 comments
Closed

Go vendoring? #28

ilovezfs opened this issue Jun 9, 2017 · 5 comments

Comments

@ilovezfs
Copy link

ilovezfs commented Jun 9, 2017

Would you be willing to start using the Go vendor directory or one of the other Go vendor systems so that we can avoid go resource blocks in the Homebrew formula?

I noticed while doing the upgrade from 0.1.1 to 0.2.0 that fsql no longer builds unless I add a go resource block for gopkg.in/oleiade/lane.v1.

It would be much appreciated if we could avoid this in the formula, as we're trying to eliminate the use of go resource blocks, so having to add them to a formula that doesn't currently need them is :(

@kashav
Copy link
Owner

kashav commented Jun 9, 2017

@ilovezfs Done!

@ilovezfs
Copy link
Author

ilovezfs commented Jun 9, 2017

Thanks! Could I convince you to create a new tag too? 😇

@kashav
Copy link
Owner

kashav commented Jun 9, 2017

@ilovezfs Published v0.2.1! 😄

@ilovezfs
Copy link
Author

ilovezfs commented Jun 9, 2017

Perfect! Thank you :)

@ilovezfs
Copy link
Author

ilovezfs commented Jun 9, 2017

@kshvmdn I've updated Homebrew/homebrew-core#14404 to be for 0.2.1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants