Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display progress of IBD process in Kaspad logs #1938

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

stasatdaglabs
Copy link
Collaborator

This implements #1912

Reports for both protocol version 3 and 4 are added, for both header and block downloads

The reports look like this:
2022-01-30 16:37:14.450 [INF] PROT: IBD: Processed 63600 blocks (28%)

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #1938 (9b173b7) into dev (4a560f2) will increase coverage by 0.09%.
The diff coverage is 82.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1938      +/-   ##
==========================================
+ Coverage   61.23%   61.33%   +0.09%     
==========================================
  Files         649      651       +2     
  Lines       31052    31114      +62     
==========================================
+ Hits        19015    19084      +69     
+ Misses       9266     9258       -8     
- Partials     2771     2772       +1     
Impacted Files Coverage Δ
app/protocol/flows/v3/blockrelay/ibd.go 43.78% <63.15%> (+0.88%) ⬆️
app/protocol/flows/v4/blockrelay/ibd.go 50.84% <68.42%> (+0.55%) ⬆️
...tocol/flows/v3/blockrelay/ibd_progress_reporter.go 100.00% <100.00%> (ø)
...ocol/flows/v3/blockrelay/ibd_with_headers_proof.go 40.86% <100.00%> (ø)
...tocol/flows/v4/blockrelay/ibd_progress_reporter.go 100.00% <100.00%> (ø)
...ocol/flows/v4/blockrelay/ibd_with_headers_proof.go 44.39% <100.00%> (ø)
infrastructure/network/rpcclient/rpcclient.go 69.66% <0.00%> (+2.24%) ⬆️
...ructure/network/rpcclient/grpcclient/grpcclient.go 81.25% <0.00%> (+4.68%) ⬆️
...rver/grpcserver/protowire/rpc_get_mempool_entry.go 72.72% <0.00%> (+6.06%) ⬆️
...ructure/network/rpcclient/rpc_get_mempool_entry.go 63.63% <0.00%> (+18.18%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a560f2...9b173b7. Read the comment docs.

Copy link
Collaborator

@someone235 someone235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also report the progress of block body progress.

@someone235 someone235 merged commit b1229f7 into kaspanet:dev Feb 2, 2022
someone235 added a commit that referenced this pull request Feb 18, 2022
* Make kaspawallet store the utxos sorted by amount, so that the bigger utxos are spent first - making it less likely a compound will be required

* Start refactor addEntryToUTXOSet

* Add GetUTXOsByBalances command to rpc

* Store list of addresses, updated with the collectAddresses methods
(replacing collectUTXOs methods)

* Fix wrong commands in GetBalanceByAddress

* Rename: refreshExistingUTXOs -> refreshUTXOs

* Display progress of IBD process in Kaspad logs (#1938)

* Report progress percentage when downloading headers in IBD.

* Extract reporting logic to a separate type.

* Report progress for IBD missing block bodies.

* Split ApplyPruningPointProof to multiple small database transactions (#1937)

* Split ApplyPruningPointProof to multiple small database transactions.

* Increase the timeout duration in TestIBDWithPruning.

* Increase the timeout duration in simple-sync.

* Explain that if ApplyPruningPointProof fails, the database must be discarded.

* Increase headers proof timeout and add more progress logs (#1939)

* Increase timeout for pruning proof and add some logs

* Show resolving virtual progress as whole percents

* Add AllowConnectionToDifferentVersions flag to kaspactl (#1940)

* Remove duplicate median time calculation on tx validation (#1943)

Co-authored-by: stasatdaglabs <39559713+stasatdaglabs@users.noreply.github.com>

* Drop support for p2p v3 (#1942)

* Drop support for p2p v3

* Remove redundant aliases

* Remove redundant condition

* In profile dump file - use a time format supporting all file systems (#1945)

* Use a time format without ":" to support all file systems

* go fmt

* Bump version to v0.11.12 (#1941)

Co-authored-by: stasatdaglabs <39559713+stasatdaglabs@users.noreply.github.com>

Co-authored-by: stasatdaglabs <39559713+stasatdaglabs@users.noreply.github.com>
Co-authored-by: Ori Newman <orinewman1@gmail.com>
Co-authored-by: Michael Sutton <mikisiton2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants