Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate median time calculation on tx validation #1943

Conversation

someone235
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #1943 (932d353) into dev (c85b5d7) will decrease coverage by 0.02%.
The diff coverage is 53.84%.

❗ Current head 932d353 differs from pull request most recent head 7a89717. Consider uploading reports for the commit 7a89717 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1943      +/-   ##
==========================================
- Coverage   61.28%   61.25%   -0.03%     
==========================================
  Files         651      651              
  Lines       31134    31139       +5     
==========================================
- Hits        19079    19073       -6     
- Misses       9275     9281       +6     
- Partials     2780     2785       +5     
Impacted Files Coverage Δ
domain/consensus/consensus.go 68.99% <50.00%> (-0.24%) ⬇️
.../consensus/processes/blockbuilder/block_builder.go 76.87% <50.00%> (-0.77%) ⬇️
.../processes/blockvalidator/block_body_in_context.go 61.85% <50.00%> (-0.92%) ⬇️
...ses/transactionvalidator/transaction_in_context.go 75.14% <100.00%> (+0.71%) ⬆️
infrastructure/network/rpcclient/rpc_get_info.go 45.45% <0.00%> (-18.19%) ⬇️
infrastructure/network/rpcclient/rpcclient.go 60.67% <0.00%> (-6.75%) ⬇️
infrastructure/network/netadapter/router/route.go 82.85% <0.00%> (-5.72%) ⬇️
cmd/kaspactl/main.go 0.00% <0.00%> (ø)
cmd/kaspactl/config.go 0.00% <0.00%> (ø)
infrastructure/network/addressmanager/store.go 79.11% <0.00%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85b5d7...7a89717. Read the comment docs.

@stasatdaglabs stasatdaglabs merged commit 69d90fe into kaspanet:dev Feb 6, 2022
someone235 added a commit that referenced this pull request Feb 18, 2022
* Make kaspawallet store the utxos sorted by amount, so that the bigger utxos are spent first - making it less likely a compound will be required

* Start refactor addEntryToUTXOSet

* Add GetUTXOsByBalances command to rpc

* Store list of addresses, updated with the collectAddresses methods
(replacing collectUTXOs methods)

* Fix wrong commands in GetBalanceByAddress

* Rename: refreshExistingUTXOs -> refreshUTXOs

* Display progress of IBD process in Kaspad logs (#1938)

* Report progress percentage when downloading headers in IBD.

* Extract reporting logic to a separate type.

* Report progress for IBD missing block bodies.

* Split ApplyPruningPointProof to multiple small database transactions (#1937)

* Split ApplyPruningPointProof to multiple small database transactions.

* Increase the timeout duration in TestIBDWithPruning.

* Increase the timeout duration in simple-sync.

* Explain that if ApplyPruningPointProof fails, the database must be discarded.

* Increase headers proof timeout and add more progress logs (#1939)

* Increase timeout for pruning proof and add some logs

* Show resolving virtual progress as whole percents

* Add AllowConnectionToDifferentVersions flag to kaspactl (#1940)

* Remove duplicate median time calculation on tx validation (#1943)

Co-authored-by: stasatdaglabs <39559713+stasatdaglabs@users.noreply.github.com>

* Drop support for p2p v3 (#1942)

* Drop support for p2p v3

* Remove redundant aliases

* Remove redundant condition

* In profile dump file - use a time format supporting all file systems (#1945)

* Use a time format without ":" to support all file systems

* go fmt

* Bump version to v0.11.12 (#1941)

Co-authored-by: stasatdaglabs <39559713+stasatdaglabs@users.noreply.github.com>

Co-authored-by: stasatdaglabs <39559713+stasatdaglabs@users.noreply.github.com>
Co-authored-by: Ori Newman <orinewman1@gmail.com>
Co-authored-by: Michael Sutton <mikisiton2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants