-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for p2p v3 #1942
Drop support for p2p v3 #1942
Conversation
app/protocol/flows/v4/register.go
Outdated
"github.com/kaspanet/kaspad/app/protocol/flows/v4/blockrelay" | ||
ping2 "github.com/kaspanet/kaspad/app/protocol/flows/v4/ping" | ||
"github.com/kaspanet/kaspad/app/protocol/flows/v4/rejects" | ||
transactionrelay2 "github.com/kaspanet/kaspad/app/protocol/flows/v4/transactionrelay" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the ping package no longer need to be aliased
app/protocol/protocol.go
Outdated
case 4: | ||
flows = v4.Register(m, router, errChan, &isStopping) | ||
default: | ||
panic(errors.Errorf("no way to handle protocol version %d", peer.ProtocolVersion())) | ||
} | ||
flows = append(flows, sendAddressesFlow) | ||
|
||
if peer.ProtocolVersion() > 3 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this condition is no longer relevant.
06ac740
to
26274b7
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1942 +/- ##
==========================================
- Coverage 61.27% 61.26% -0.01%
==========================================
Files 651 636 -15
Lines 31140 29961 -1179
==========================================
- Hits 19080 18356 -724
+ Misses 9278 8995 -283
+ Partials 2782 2610 -172
Continue to review full report at Codecov.
|
* Make kaspawallet store the utxos sorted by amount, so that the bigger utxos are spent first - making it less likely a compound will be required * Start refactor addEntryToUTXOSet * Add GetUTXOsByBalances command to rpc * Store list of addresses, updated with the collectAddresses methods (replacing collectUTXOs methods) * Fix wrong commands in GetBalanceByAddress * Rename: refreshExistingUTXOs -> refreshUTXOs * Display progress of IBD process in Kaspad logs (#1938) * Report progress percentage when downloading headers in IBD. * Extract reporting logic to a separate type. * Report progress for IBD missing block bodies. * Split ApplyPruningPointProof to multiple small database transactions (#1937) * Split ApplyPruningPointProof to multiple small database transactions. * Increase the timeout duration in TestIBDWithPruning. * Increase the timeout duration in simple-sync. * Explain that if ApplyPruningPointProof fails, the database must be discarded. * Increase headers proof timeout and add more progress logs (#1939) * Increase timeout for pruning proof and add some logs * Show resolving virtual progress as whole percents * Add AllowConnectionToDifferentVersions flag to kaspactl (#1940) * Remove duplicate median time calculation on tx validation (#1943) Co-authored-by: stasatdaglabs <39559713+stasatdaglabs@users.noreply.github.com> * Drop support for p2p v3 (#1942) * Drop support for p2p v3 * Remove redundant aliases * Remove redundant condition * In profile dump file - use a time format supporting all file systems (#1945) * Use a time format without ":" to support all file systems * go fmt * Bump version to v0.11.12 (#1941) Co-authored-by: stasatdaglabs <39559713+stasatdaglabs@users.noreply.github.com> Co-authored-by: stasatdaglabs <39559713+stasatdaglabs@users.noreply.github.com> Co-authored-by: Ori Newman <orinewman1@gmail.com> Co-authored-by: Michael Sutton <mikisiton2@gmail.com>
No description provided.