Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kaspawallet ignore outputs that exist in the mempool #2053

Merged
merged 3 commits into from
May 19, 2022

Conversation

someone235
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #2053 (ec9a105) into dev (016ddfd) will decrease coverage by 0.01%.
The diff coverage is 3.03%.

❗ Current head ec9a105 differs from pull request most recent head e150ac7. Consider uploading reports for the commit e150ac7 to get more accurate results

@@            Coverage Diff             @@
##              dev    #2053      +/-   ##
==========================================
- Coverage   59.43%   59.41%   -0.02%     
==========================================
  Files         673      673              
  Lines       32305    32332      +27     
==========================================
+ Hits        19200    19210      +10     
- Misses      10346    10363      +17     
  Partials     2759     2759              
Impacted Files Coverage Δ
cmd/kaspawallet/daemon/server/broadcast.go 0.00% <0.00%> (ø)
...allet/daemon/server/create_unsigned_transaction.go 0.00% <0.00%> (ø)
cmd/kaspawallet/daemon/server/server.go 0.00% <0.00%> (ø)
cmd/kaspawallet/daemon/server/sync.go 0.00% <0.00%> (ø)
...pc/rpchandlers/get_mempool_entries_by_addresses.go 81.35% <25.00%> (-4.36%) ⬇️
...k/netadapter/server/grpcserver/connection_loops.go 60.34% <0.00%> (+3.44%) ⬆️
...selectedchainstore/headers_selected_chain_store.go 75.58% <0.00%> (+3.48%) ⬆️
...ain/consensus/database/binaryserialization/hash.go 78.26% <0.00%> (+8.69%) ⬆️
...tructure/network/rpcclient/rpc_on_chain_changed.go 66.66% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 016ddfd...e150ac7. Read the comment docs.

@someone235 someone235 merged commit 5f7cc07 into kaspanet:dev May 19, 2022
@someone235 someone235 deleted the avoid-spending-mempool branch May 19, 2022 13:12
@D-Stacks D-Stacks mentioned this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants