-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for zero-valued alpha parameter #3
Comments
There are two places we can deal with this, and I suggest we use both.
update Option 3: Don't report alpha until the potential is reporting that it has completed training. I think this is logically a separate (but related) issue / feature. |
It is reasonable to initialize the struct with If anything, we could add a check to the plugin interface that requires an explicit alpha and checks whether it is zero. But none of us seem to think this is necessary, given the updated checks in |
It doesn't make sense for
alpha
to be zero unless a developer is testing a restraint that should not apply forces. However, under some circumstances, run_brer could accidentally set alpha=0. We should check for this and either issue a warning or raise an error that can be optionally disabled.The text was updated successfully, but these errors were encountered: