Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Decide on docker version strategy #373

Closed
jodh-intel opened this issue Feb 4, 2019 · 7 comments
Closed

Decide on docker version strategy #373

jodh-intel opened this issue Feb 4, 2019 · 7 comments
Labels
medium-priority Urgent issue (resolve before unprioritised issues)

Comments

@jodh-intel
Copy link
Contributor

Docker removed devicemapper in 18.09 which complicates life for many (see kata-containers/runtime#1112).

Our install docs setup the docker repo and then help users install the latest version of docker. Given the above, that's a potential problem so we need to find a non-gross way of updating the install docs to install docker 18.06.

The approach needs to:

Since the docker package will get auto-upgraded from 18.06 -> 18.09 when the user upgrades their installed packages, we're basically going to have to apt-mark hold docker I think:

We'll also have to find the appropriate distro rune for each other install doc and then remove it if/when docker can be upgraded once again. And add a "note" explaining what the extra step is for.

/cc @egernst.
@jodh-intel
Copy link
Contributor Author

jodh-intel commented Feb 4, 2019 •
edited
Loading

The most annoying bit is going to be having to specify the precise package version of docker the user needs to both install and hold given that, for example, on Ubuntu the user will need to run:

$ sudo apt -y install docker-ce='18.06.1~ce~3-0~ubuntu'
$ sudo apt-mark hold docker-ce

That package version format may be different for each distro repo.

@jodh-intel jodh-intel added the medium-priority Urgent issue (resolve before unprioritised issues) label Feb 4, 2019
jodh-intel added a commit to jodh-intel/documentation that referenced this issue Feb 5, 2019
@jodh-intel
docs: Pin docker to version 18.06
ee7fa79 
Docker 18.09 removed devicemapper support but did not provide an
alternative. This can cause problems for users so update the install
docs to install Docker at version 18.06 (the last version that supports
devicemapper).

This is a temporary solution until either docker provide an alternative
or we find a way to work around the Docker feature being removed.

Fixes kata-containers#373.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel jodh-intel mentioned this issue Feb 5, 2019
Merged
jodh-intel added a commit to jodh-intel/documentation that referenced this issue Feb 5, 2019
@jodh-intel
docs: Pin docker to version 18.06
c9d6f59 
Docker 18.09 removed devicemapper support but did not provide an
alternative. This can cause problems for users so update the install
docs to install Docker at version 18.06 (the last version that supports
devicemapper).

This is a temporary solution until either docker provide an alternative
or we find a way to work around the Docker feature being removed.

Note the extra logic required for Fedora since 18.06 is not available
for that release.

Fixes kata-containers#373.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel added a commit to jodh-intel/documentation that referenced this issue Feb 5, 2019
@jodh-intel
docs: Pin docker to version 18.06
85dc9c7 
Docker 18.09 removed devicemapper support but did not provide an
alternative. This can cause problems for users so update the install
docs to install Docker at version 18.06 (the last version that supports
devicemapper).

This is a temporary solution until either docker provide an alternative
or we find a way to work around the Docker feature being removed.

Note the extra logic required for Fedora since 18.06 is not available
for that release.

Fixes kata-containers#373.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel
Copy link
Contributor Author

Related:

jodh-intel added a commit to jodh-intel/documentation that referenced this issue Feb 6, 2019
@jodh-intel
docs: Pin docker to version 18.06
a20e46b 
Docker 18.09 removed devicemapper support but did not provide an
alternative. This can cause problems for users so update the install
docs to install Docker at version 18.06 (the last version that supports
devicemapper).

This is a temporary solution until either docker provide an alternative
or we find a way to work around the Docker feature being removed.

Note the extra logic required for Fedora since 18.06 is not available
for that release.

Fixes kata-containers#373.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel added a commit to jodh-intel/documentation that referenced this issue Feb 6, 2019
@jodh-intel
docs: Pin docker to version 18.06
09f7479 
Docker 18.09 removed devicemapper support but did not provide an
alternative. This can cause problems for users so update the install
docs to install Docker at version 18.06 (the last version that supports
devicemapper).

This is a temporary solution until either docker provide an alternative
or we find a way to work around the Docker feature being removed.

Note the extra logic required for Fedora since 18.06 is not available
for that release.

Fixes kata-containers#373.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel added a commit to jodh-intel/documentation that referenced this issue Feb 6, 2019
@jodh-intel
docs: Pin docker to version 18.06
7a49371 
Docker 18.09 removed devicemapper support but did not provide an
alternative. This can cause problems for users so update the install
docs to install Docker at version 18.06 (the last version that supports
devicemapper).

This is a temporary solution until either docker provide an alternative
or we find a way to work around the Docker feature being removed.

Note the extra logic required for Fedora since 18.06 is not available
for that release.

Fixes kata-containers#373.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel added a commit to jodh-intel/documentation that referenced this issue Feb 6, 2019
@jodh-intel
docs: Pin docker to version 18.06
fa23540 
Docker 18.09 removed devicemapper support but did not provide an
alternative. This can cause problems for users so update the install
docs to install Docker at version 18.06 (the last version that supports
devicemapper).

This is a temporary solution until either docker provide an alternative
or we find a way to work around the Docker feature being removed.

Note the extra logic required for Fedora since 18.06 is not available
for that release.

Fixes kata-containers#373.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel added a commit to jodh-intel/documentation that referenced this issue Feb 8, 2019
@jodh-intel
docs: Pin docker to version 18.06
a9ce5ff 
Docker 18.09 removed devicemapper support but did not provide an
alternative. This can cause problems for users so update the install
docs to install Docker at version 18.06 (the last version that supports
devicemapper).

This is a temporary solution until either docker provide an alternative
or we find a way to work around the Docker feature being removed.

Note the extra logic required for Fedora since 18.06 is not available
for that release.

Fixes kata-containers#373.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel added a commit to jodh-intel/documentation that referenced this issue Feb 18, 2019
@jodh-intel
docs: Pin docker to version 18.06
31dd5eb 
Docker 18.09 removed devicemapper support but did not provide an
alternative. This can cause problems for users so update the install
docs to install Docker at version 18.06 (the last version that supports
devicemapper).

This is a temporary solution until either docker provide an alternative
or we find a way to work around the Docker feature being removed.

Note the extra logic required for Fedora since 18.06 is not available
for that release.

Fixes kata-containers#373.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel added a commit to jodh-intel/documentation that referenced this issue Feb 18, 2019
@jodh-intel
docs: Pin docker to version 18.06
ceae7b4 
Docker 18.09 removed devicemapper support but did not provide an
alternative. This can cause problems for users so update the install
docs to install Docker at version 18.06 (the last version that supports
devicemapper).

This is a temporary solution until either docker provide an alternative
or we find a way to work around the Docker feature being removed.

Note the extra logic required for Fedora since 18.06 is not available
for that release.

Fixes kata-containers#373.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@egernst
Copy link
Member

egernst commented Mar 4, 2019

@jodh-intel -- we have this covered now, right?

@jodh-intel
Copy link
Contributor Author

From an immediate doc perspective, yes, I think this is resolved by #374.

However, that approach can only be a temporary solution as we don't want users to be pinned to what will soon become an old version. As such, re-opening to allow us to discuss a more permanent solution...

@jodh-intel jodh-intel reopened this Mar 5, 2019
@jodh-intel
Copy link
Contributor Author

@kata-containers/architecture-committee - we had to pin docker to version 18.06.2 on #374. But time has moved on and Docker has released the following versions:

  • 18.06.3
  • 18.09.0
  • 18.09.1
  • 18.09.2
  • 18.09.3

We need to remove the requirement that users stay on docker 18.06.

@jodh-intel jodh-intel mentioned this issue Mar 21, 2019
Closed
@chavafg
Copy link
Contributor

chavafg commented Mar 28, 2019

#409 has landed, should we also change our versions.yaml to use 18.09 ? We are still testing with 18.06... So far all docker testing is using overlay

@jodh-intel
Copy link
Contributor Author

+1 for moving to 18.09 as that is now what users will be installing by default if they follow our install guides.

/cc @ganeshmaharaj, @amshinde, @mcastelino.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
medium-priority Urgent issue (resolve before unprioritised issues)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chavafg @egernst @jodh-intel