Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[POLL] Iris + Go Modules (Import path suffix or not) #1370
Hello Iris Community,
As you know the Go Team released the go modules.
There are two opened issues:
I would like to have your opinion on a serious subject about the import path. There are two ways to fix the above.
The first one is to keep the same import path and do:
$ go get github.com/kataras/iris@master
This will add a pseudo-version inside your project's
require ( github.com/kataras/iris v0.0.0-20191005193354-55afd07befa8 )
The import paths inside your program should look like that:
package mypackage import "github.com/kataras/iris" import "github.com/iris-contrib/middleware/cloudwatch"
However, tools like
The second solution one is to increment the major version, replace and keep updating all import paths inside Iris and iris-contrib/middleware, iris-contrib/examples and e.t.c. to
$ go get github.com/kataras/iris@v12
This should download the latest tagged version of
require( github.com/kataras/iris v12.0.0 )
package mypackage import "github.com/kataras/iris/v12" import "github.com/iris-contrib/middleware/cloudwatch/v12" // [...]
There are several downsides of changing the import path, as it is a huge breaking change but in the same time it's the standard Go's way nowadays.
Please think of it and vote up what you would like to happen here.