-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage failing with version 0.3.6 and up #75
Comments
Can you tell me if If it does, this is likely the same (or related to the same root cause) as #66. |
@rwjblue Not sure. What would you like me to do to test that |
Run |
@rwjblue Yes there is an error. |
Any suggestions on how to debug/work around this? As far as I can tell there is no custom |
Related to #66 as in my case it seems to be a conflict with mocha's require. |
Bump. I've been running into the same issue: not ok 219 Chrome 54.0 - Global error: Uncaught TypeError: Cannot convert undefined or null to object at http://localhost:7357/assets/vendor.js, line 73209
---
Log: |
{ type: 'error',
text: 'Uncaught TypeError: Cannot convert undefined or null to object at http://localhost:7357/assets/vendor.js, line 73209\n' }
...
not ok 220 Chrome 54.0 - JSHint | unit/mixins/table-header-test.js: global failure
---
actual: >
null
stack: >
http://localhost:7357/assets/vendor.js:73209
message: >
Uncaught TypeError: Cannot convert undefined or null to object
Log: |
...
Running on ember-light-table w/ ember-cli-code-coverage@0.3.8 |
@offirgolan are you using something that redefines the global |
When running what @rwjblue suggested
I get the same error. |
I have made a PR to unblock those who are facing this issue. It's a simple This doesn't fix any underlying issues with conflicting versions of require but it unblocks those who have conflicting versions. |
In case anyone else is still having an issue with an overwritten (got the <script>
console = console || {}; // just in case
console.watch = function(oObj, sProp) {
sPrivateProp = "$_"+sProp+"_$"; // to minimize the name clash risk
oObj[sPrivateProp] = oObj[sProp];
// overwrite with accessor
Object.defineProperty(oObj, sProp, {
get: function () {
return oObj[sPrivateProp];
},
set: function (value) {
//console.log("setting " + sProp + " to " + value);
debugger; // sets breakpoint
oObj[sPrivateProp] = value;
}
});
}
console.watch(window, 'require')
</script> And then ran my tests in the browser (I used Still tracking down exactly where the file EDIT: I tracked it down, looks like |
I opened ef4/ember-code-snippet#34 to bring it to the attention of the authors of |
As mentioned above, this has to do with other addons (in our case |
I seem to have an issue with v 0.3.6+ of ember-cli-code-coverage.
Running
COVERAGE=true ember test
kept failing after the last test was run ie when coverage would normally start. Its not repo specific. Doesnt matter what the tests are, this error always shows up at the endI have pin pointed this to version 0.3.6 of ember-cli-code-coverage. Up to 0.3.5 everything works great. If you pin to v 0.3.5, coverage is reported properly. Could be related to this PR https://github.com/kategengler/ember-cli-code-coverage/pull/62/files
@rwjblue @rwwagner90
The text was updated successfully, but these errors were encountered: