-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Improvements #271
Comments
tcaiazzi
added a commit
that referenced
this issue
Feb 1, 2024
Co-Authored-By: Mariano Scazzariello <marianoscazzariello@gmail.com>
tcaiazzi
added a commit
that referenced
this issue
Feb 1, 2024
Co-Authored-By: Mariano Scazzariello <marianoscazzariello@gmail.com>
tcaiazzi
added a commit
that referenced
this issue
Feb 5, 2024
tcaiazzi
added a commit
that referenced
this issue
Feb 5, 2024
tcaiazzi
added a commit
that referenced
this issue
Feb 5, 2024
tcaiazzi
added a commit
that referenced
this issue
Feb 5, 2024
tcaiazzi
added a commit
that referenced
this issue
Feb 6, 2024
tcaiazzi
added a commit
that referenced
this issue
Feb 6, 2024
tcaiazzi
added a commit
that referenced
this issue
Feb 7, 2024
tcaiazzi
added a commit
that referenced
this issue
Feb 22, 2024
Now it is possible to pass regex as searched line in the following FilesystemMixin methods: - `write_line_before` - `write_line_after` - `delete_line`
tcaiazzi
added a commit
that referenced
this issue
Feb 28, 2024
tcaiazzi
added a commit
that referenced
this issue
Feb 29, 2024
tcaiazzi
added a commit
that referenced
this issue
Feb 29, 2024
tcaiazzi
added a commit
that referenced
this issue
Feb 29, 2024
tcaiazzi
added a commit
that referenced
this issue
Feb 29, 2024
tcaiazzi
added a commit
that referenced
this issue
Feb 29, 2024
Skazza94
added a commit
that referenced
this issue
Mar 4, 2024
Skazza94
added a commit
that referenced
this issue
Mar 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following list outlines several enhancements and fixes required to improve methods and parameters clarity, maintainability, and usability of Python APIs.
**kwargs
should not have type, for exampleLab.new_machine(self, name: str, **kwargs: Dict[str, Any])
gives a warning in PyCharmManager
methodcopy_files(self, machine: Machine, guest_to_host: Dict[str, io.IOBase])
,guest_to_host
should beDict[str, Union[str, io.IOBase]]
sinceutils.pack_file_for_tar
acceptsfile_obj
with that type.lab.check_integrity
should be moved insidedeploy_lab
of Managersdeploy_machine
privileged
andlab.ext
) inside the Managers instead of command (otherwise it is not raised by API). Forlab.ext
it should also be done in_attach_external_interfaces
inDockerLink
. Forprivileged
it should also be done inDockerManager
.connect_tty_obj
that takesMachine
object instead of name and no lab params, that internally calls theconnect_tty
with the right paramsexec_obj
that takesMachine
object instead of name and no lab params, that internally calls theexec
with the right paramsget_machine_stats_obj
that takesMachine
object instead of name and no lab params, that internally calls theget_machine_stats
with the right paramsget_link_stats_obj
that takesLink
object instead of name and no lab params, that internally calls theget_link_stats
with the right paramsstream=True/False
parameter inexec
that, ifFalse
, unrolls the stream and returns thebytes
results.PrivilegeError
ofmachine_stats
ifall_users=True
is now inListCommand
FilesystemMixin
should also take a Regex instead of a stringThe text was updated successfully, but these errors were encountered: