-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make more compatible for browser use. Pass TypeScript checks #51
Comments
I will be avaliable for the publish, but i already added you as a collaborator so you should be able to publish also |
Please check out my push when you get a chance. Change log
|
I'm going to try and publish this code to npm. I feel real confident of it and in need of it for my team. |
@AckerApple go for it! |
Published. I really am humbled and extra appreciative of being entrusted to maintain and publish this package. Quite the honor. |
@AckerApple I am honoured to have you helping maintaining this package! |
Would be cool to cross your path someday. Your github icon is soulfully great to see, zoomed in to see you got a smile. Little things, the little things. |
Yes, i want to meet you too! send me an email (check my gh profile) with your skype, whatsapp or telegram info =) |
When compiling code for updated versions of TypeScript, it now checks the require statements and several errors are being thrown:
It seems require('stream') and require('os') are not even really needed for the browser. The EOL can just be backslash "\n" in the browser. And stream is not needed if a callback is provided.
I manually edited the node_modules/jsonexport files and all came out well and built to browser. I will need to find the most compatible way to have all files live in harmony and that the dist folder has NO node based requires.
Will have to complete this with-in a weeks time at max. Please be available to publish to npm when I have completed
The text was updated successfully, but these errors were encountered: