Skip to content
This repository has been archived by the owner on May 18, 2018. It is now read-only.

Suggest using a path library for joining paths #12

Open
JaikrishnaTS opened this issue Mar 31, 2018 · 2 comments
Open

Suggest using a path library for joining paths #12

JaikrishnaTS opened this issue Mar 31, 2018 · 2 comments

Comments

@JaikrishnaTS
Copy link

shutil.copy2(base_path + firewall_script_name, firewall_path + firewall_script_name)

os.path.join and pathlib.Path are good choices.

@JaikrishnaTS
Copy link
Author

Also at

path_for_logs.append(current_dir+"/docker_log")
path_for_backup.append(current_dir+"/docker_log_backup")
path_for_diff.append(current_dir+"/docker_log_diff")

@kausrini
Copy link
Owner

kausrini commented Apr 2, 2018

Needs extensive restructuring to incorporate the pathlib module to this project. Moving to such an object oriented model is beneficial in the long run.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants