Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dense and filter pipes generate a lot of paths #7

Closed
redstoneguy12 opened this issue Aug 10, 2020 · 6 comments
Closed

Dense and filter pipes generate a lot of paths #7

redstoneguy12 opened this issue Aug 10, 2020 · 6 comments

Comments

@redstoneguy12
Copy link

Steps to reproduce:

  1. Build this
    The system that causes the issue
  2. Click on the puller with a pipe probe

Not only does this make it annoying to diagnose your system, it probably causes lag too

@redstoneguy12
Copy link
Author

redstoneguy12 commented Aug 10, 2020

I can confirm that it causes a lot of lag, it brings my server to 10 TPS whenever I update my network with one of those arrays in it (with 6 filters, each connected to two chests). It does not seem to cause too much lag when I push items through the system, however.

@cakewhip
Copy link
Collaborator

I agree that too many paths are being generated; I'll most likely have the system always take the lowest priority pathing. But yes, because EZPaS pre-calculates insertion points, the only lag you'll mostly experience is from changing any part of the system. To avoid this, you could disconnect any puller pipes and make changes.

On a side note, that system would not behave similar to other pipe mod systems. The right-most chest would have all three filters placed on it. This is an intended effect as items are treated similar to a liquid going through pipes.

@redstoneguy12
Copy link
Author

On a side note, that system would not behave similar to other pipe mod systems. The right-most chest would have all three filters placed on it. This is an intended effect as items are treated similar to a liquid going through pipes.

So the filter above that chest has a grass block in it. The hope is that this would behave like a traditional bulk storage unit and only grass blocks would be able to go into that chest, but I didn't actually test it. Are you saying that's not the case, and that grass blocks couldn't go into it?

@cakewhip
Copy link
Collaborator

No, I mean that items going into the last chest would have to go through every filter. So if the first filter had X block in it and the last filter had Y block in it, Y block would not be able to enter the chest since it does not past the first filter.

@redstoneguy12
Copy link
Author

But that's what the dense pipes are for, they can't just go through the dense pipes?

@cakewhip
Copy link
Collaborator

The dense pipes are doing their job, but if you look at the filtered pipes they are connected to each other. Items will take the path of least resistance.

This conversation is getting a bit out of scope, so I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants