Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GK1 decompilation crashes #8

Closed
ZvikaZ opened this issue Sep 9, 2020 · 3 comments
Closed

GK1 decompilation crashes #8

ZvikaZ opened this issue Sep 9, 2020 · 3 comments

Comments

@ZvikaZ
Copy link

ZvikaZ commented Sep 9, 2020

Hi.

I'm trying to decompile GK1 with latest version (from Kawa's stash), and it crashes in the middle.
With older version it worked well.

Thanks.
@Kawa-oneechan
Copy link
Owner

It was my hack to make the LSL3 demo decompile correctly. Easy to believe, really.

Kawa-oneechan added a commit that referenced this issue Sep 9, 2020
@Kawa-oneechan
Update DecompilerNew.cpp
ff51cdf 
Add extra validity check on pNodePrevious so GK1 manages to decompile, as discovered in #8.
@Kawa-oneechan
Copy link
Owner

New build is now available from the Stash that managed to decompile GK1 (disk version) without crashing on the Str class as well as the LSL3 demo (if given the real game's selector vocab) without thinking every selector is species.

If you could please confirm this on your side...

@ZvikaZ
Copy link
Author

ZvikaZ commented Sep 10, 2020

It's indeed working (on GK1).
Congratulations for the new look.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZvikaZ @Kawa-oneechan