Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add msgpack.isSupported for the browser version #30

Closed
mozi opened this issue Mar 1, 2016 · 5 comments
Closed

add msgpack.isSupported for the browser version #30

mozi opened this issue Mar 1, 2016 · 5 comments

Comments

@mozi
Copy link

mozi commented Mar 1, 2016

No description provided.

@kawanet
Copy link
Owner

kawanet commented Mar 1, 2016

Is it a method?

if (msgpack.isSupported("feature", "version")) { ... }

Could you let me know a use case?

@mozi
Copy link
Author

mozi commented Mar 1, 2016

It could be a method or it could be a property.
The use case is simply the library doesn't work on Android 6 built-in browser, and noticed its not supported on the homepage as well, so it would be helpful to have a method available on the browser version to detect if it can work with the browser the user using.

@kawanet
Copy link
Owner

kawanet commented Mar 2, 2016

@mozi It looks it works on Android 6.0 built-in browser, by the way.
Did you see any error messages?

@kawanet
Copy link
Owner

kawanet commented Mar 2, 2016

It passes all tests on Android 6.0 built-in browser.

make test-browser-local

Try http://192.168.xxx.xxx:4000/__zuul then.

It looks that SauceLab does not support 6.0 still however.

@mozi
Copy link
Author

mozi commented Mar 7, 2016

Thanks, I can confirm that it is indeed working on Android 6 native browser.

@mozi mozi closed this as completed Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants