Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add preemptible bool to optimization request #37

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

artaasadi
Copy link
Collaborator

Description

What type of PR(Pull Request) is this?

  • πŸ› Bug Fix
  • πŸ• New Feature
  • πŸ”₯ Performance Improvement
  • πŸ“ Documentation update
  • βœ… Test
  • πŸ€– Build
  • πŸ“¦ Release
  • πŸ” CI/CD

Added to documentation?

  • πŸ“œ README.md
  • 🀝 CONTRIBUTING.md
  • πŸ™… no documentation needed

Bug Fix

  1. Explain how you addressed the issue.
  2. Ensure the issue is linked in your description using "Fixes #XXXX."

New Feature

  1. Provide a clear explanation of your new feature.
  2. Include relevant tests for the new feature.
  3. Confirm successful local testing of your changes.
  4. Update the relevant documentation (if applicable).

Performance Improvement

  1. Confirm successful local testing of the performance improvement.
  2. If possible, include metrics demonstrating the improvement.

General Notes

  1. Ensure your PR is not a duplicate.
  2. If not, make sure that:
    1. Changes are in a separate branch with a descriptive name (e.g., fix-cost-command or feature-add-newCommand).
    2. Commit message has a short, descriptive title.
  3. After these steps,open a pull request.
    1. Target the contributor branch, not main.
    2. Resolve any GitHub workflow test errors before committing.
    3. Include "closes #XXXX" in your comment to auto-close the relevant issue (if applicable).
    4. Describe your changes.
    5. Put the "closest #XXXX" text in your comment to auto-close the issue your PR is fixing (if such).

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@artaasadi artaasadi merged commit b285c61 into main Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant