Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration and output clean up #6

Closed
kazewong opened this issue Apr 28, 2022 · 6 comments
Closed

Configuration and output clean up #6

kazewong opened this issue Apr 28, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@kazewong
Copy link
Owner

  1. Clean up configuration dictionary
  2. Fix output format to interface with arviz
@kazewong kazewong mentioned this issue May 3, 2022
@kazewong
Copy link
Owner Author

kazewong commented May 3, 2022

For configuration, we should look into different options for configuration.

I think .yaml and Hydra is pretty good for this purpose https://hydra.cc/
Once we have decided, we can move forward in moving the config dictionary out of the example script.

@kazewong kazewong changed the title Documentation and output Configuration and output clean up May 3, 2022
@kazewong kazewong added the enhancement New feature or request label May 3, 2022
@dfm
Copy link
Collaborator

dfm commented May 3, 2022

I have so many opinions about this. I am confident that yaml and hydra are not the right choices... Happy to chat more!

@marylou-gabrie
Copy link
Collaborator

marylou-gabrie commented May 4, 2022

Concerning the output - we should also think of the right data structure to collect all of our outputs. Desired outputs already mentioned:

  • chains (-> which format? One of the traditional sampling package, including to have named variables?)
  • NF learned weights
  • global/local acceptance
  • NF loss over training iterations

@kazewong
Copy link
Owner Author

kazewong commented May 4, 2022

I have so many opinions about this. I am confident that yaml and hydra are not the right choices... Happy to chat more!

@dfm I don't have strong opinion on how to do this, happy to learn about different options!

@kazewong
Copy link
Owner Author

In branch samplerCleanUp commit a473131,
the configuration parameters are moved within the sampler class.

It doesn't necessarily shorten the examples, but the variables are more well defined since they are variables within a class instead of key-value pairs in a dict.

Tested in dual moon example.

@kazewong
Copy link
Owner Author

kazewong commented Jul 5, 2022

Sampler clean up seems to be done with #10. Closing this issue.

@kazewong kazewong closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants