Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls failures are misleading #641

Open
obormot opened this issue Sep 26, 2022 · 3 comments
Open

Coveralls failures are misleading #641

obormot opened this issue Sep 26, 2022 · 3 comments
Assignees

Comments

@obormot
Copy link
Collaborator

obormot commented Sep 26, 2022

Those "coverage decreased" failures are bogus and appear when the coverage has not changed at all, which can be confirmed by looking at the detailed report in Coveralls. There should be a setting that can be tweaked to fix this.
image

@kbandla
Copy link
Owner

kbandla commented Sep 26, 2022

I will look into this.
A quick look reveals what coveralls thinks is wrong.

@obormot
Copy link
Collaborator Author

obormot commented Sep 26, 2022

Yes it does report something, but this specific piece of code didn't change => there's no drop in coverage. Perhaps there's a threshold that can be adjusted, like "treat any change below 0.1% as no change"

@obormot
Copy link
Collaborator Author

obormot commented Nov 12, 2022

Here's another example of this. PR #646 - no change in coverage; Coveralls is all over the place.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants