Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different wavelength units? #11

Open
jvines opened this issue Jun 28, 2019 · 1 comment
Open

Different wavelength units? #11

jvines opened this issue Jun 28, 2019 · 1 comment

Comments

@jvines
Copy link

jvines commented Jun 28, 2019

Hi @kbarbary,

Would it be possible to implement different units for the wavelength to calculate the extinction?

@kbarbary
Copy link
Owner

It's possible. It would just involve expanding this section: https://github.com/kbarbary/extinction/blob/master/extinction.pyx#L163-L166 in each of the functions, and adding a new convert wavelength function.

However, it may be easier to convert your inputs to inverse microns or angstroms. extinction provides two common options, but it's not meant to replace a real unit library like astropy.units, pint, or unyt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants