Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #308

Closed
wants to merge 3 commits into from
Closed

Dev #308

wants to merge 3 commits into from

Conversation

sebhtml
Copy link
Contributor

@sebhtml sebhtml commented May 27, 2015

No description provided.

@levinas
Copy link
Contributor

levinas commented May 27, 2015

What's the purpose of the changes in the client file?

@sebhtml
Copy link
Contributor Author

sebhtml commented May 27, 2015

The changes in client.py are to make the code clearer. It is not actually something
significant anyway. I made this change while I was working on a code path related
to data upload to Shock. This is why I ended up in client.py.

@sebhtml
Copy link
Contributor Author

sebhtml commented May 28, 2015

Should I resubmit without the changes to client.py ?

@levinas
Copy link
Contributor

levinas commented May 28, 2015

yes, please

On Thu, May 28, 2015 at 2:01 PM, Sébastien Boisvert <
notifications@github.com> wrote:

Should I resubmit without the changes to client.py ?


Reply to this email directly or view it on GitHub
#308 (comment).

@sebhtml
Copy link
Contributor Author

sebhtml commented May 28, 2015

OK, I am closing this pull request then. I will submit a new pull request.

@sebhtml sebhtml closed this May 28, 2015
@sebhtml sebhtml deleted the dev branch May 28, 2015 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants