-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement OAuth2 PKCE #354
Comments
Note that since this will require storing the challenge key in the DB at the start of the login process (which currently doesn't result in any DB changes), we might as well store the Edit - if we do this for login we should do it for link as well, which makes me think we should split up this work into two parts, with separate issues:
|
Note that these changes will cause any in flight logins and links to fail on server restart. Strategy of attack:
|
Note that OrcID does not support PKCE. Google and Globus do, however: ORCID/ORCID-Source#5977 |
Additional security for the OAuth2 code flow
https://oauth.net/2/pkce/
The text was updated successfully, but these errors were encountered: