Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ease dev campaign merge with Erik's orphaned changes and add first data api widget #171

Merged
merged 25 commits into from
Oct 16, 2015
Merged

Conversation

eapearson
Copy link

Merged upstream kbase with my changes from the end of the ease-dev sprint
Fixed problems (mostly just missing dev plugins)
Added data api
Converted genome lineage widget to data api
Minor other fixes to patch it up for better demoing (and more of this to go).
Minor fixes to enable grunt test to pass.
TODO: follow up on the mass edits for q->bluebird (esp usage of done.)

Thus can be in the same directory as server.yml
moved in to separate plugin repos
TODO: some formatting issues on the landing page, unrelated.
removed unused sample panel, fixed typo in a widget.
@briehl
Copy link
Contributor

briehl commented Oct 16, 2015

It looks like a bunch of files were removed - including a number of vis widgets. Are those preserved somewhere? Were they being used?

@eapearson
Copy link
Author

Yeah, let me add those back in first. They were moved to an external repo and that should be brought in in the config, but was was lost in a merge conflict rest. Afaik they are not currently used except for demoing in ease-dev, is that right? In any case, I'll restore them 2nite. Also, need to fix narrativeManager (which I did in another copy of ui-common and does not take long, but that was separate from this merge.)

fix routing of login/logout;
add auth check for routes; 
remove gravatar from user search
briehl added a commit that referenced this pull request Oct 16, 2015
Ease dev campaign merge with Erik's orphaned changes and add first data api widget
@briehl briehl merged commit a689790 into kbaseattic:ease-dev-campaign Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants