Versionless subcommand setting does not take effect

[jimmycuadra]

AppSetting::VersionlessSubCommands doesn't seem to disable the -V/--version options on subcommands as the docs describe:

extern crate clap;

use clap::{App, AppSettings, SubCommand};

fn main() {
    let matches = App::new("example")
        .setting(AppSettings::VersionlessSubcommands)
        .version(env!("CARGO_PKG_VERSION"))
        .subcommand(
            SubCommand::with_name("sub")
        )
        .get_matches();
}

Example executions:

$ prog -V
prog 0.1.0
$ prog sub -V
prog-sub
$ prog sub -h
prog-sub

USAGE:
    prog sub [FLAGS]

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

Using clap 1.4.5 and Rust 1.3 on OS X.

[kbknapp]

Ah, that's actually an oversight in logic on our behalf. It's working as designed, but the design if flawed 😄

AppSettings::VersionlessSubcommands merely disables inheriting the parent command's version number...but you're correct it should also disable the -V, --version flags.

Thanks! 👍

[kbknapp]

#330 fixes this. Once this merges, I'll put 1.4.6 out on crates.io 😉

[kbknapp]

v1.4.6 is out on crates.io

[jimmycuadra]

Looks like the changelog needs to be regenerated. Thanks for the fixes this week! I love clap.

[kbknapp]

That's just because homu hasn't merged #331 yet, once that's done it should be updated. Thanks again for filing the bug reports! 👍