emit payload overwritten

[AndresSepar]

Hi, @kbrsh... when you emit something like:

instance.emit('doSomething', {product: 'cheese', type: 'cheddar'});

// emit overwrites the property 'type' with emit eventName param 'doSomething'
console.log(payload); // {product: 'cheese', type: 'doSomething'}

I think that emit payload could be:

{
  data: {product: 'cheese', type: 'cheddar'},
  type: 'doSomething'
}

[kbrsh]

How about something like:

instance.on("foo", (type, data) => {
  console.log(type, data);
});

instance.emit("foo", {bar: 3}); // note: data doesn't have to be an object

[AndresSepar]

Looks good!

[kbrsh]

Awesome! I'll definitely add this once I'm done rewriting the virtual DOM engine. This change should actually reduce the size a little, but is breaking and will come in v1.

[AndresSepar]

In this way, type could be an optional param:

instance.on("foo", (data, type) => {
  console.log(data, type);
});

[kbrsh]

Looking good! I think I should actually remove the type completely except for the global event.

instance.on("foo", (data) => {
  // data can be anything
});

instance.on("*", (type, data) => {
  // access to both the type of event and the data passed
});

[AndresSepar]

Great idea!